wayland: Don't spew warnings for blank cursors
authorMatthias Clasen <mclasen@redhat.com>
Wed, 12 Apr 2017 17:56:49 +0000 (13:56 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Thu, 26 Oct 2017 04:29:10 +0000 (00:29 -0400)
We were unnecessarily spewing warnings when blank cursors
were getting a new scale set. Standardize on "none" as the
name for blank cursors, and avoid the warning.

https://bugzilla.gnome.org/show_bug.cgi?id=775217

gdk/wayland/gdkcursor-wayland.c

index ab50755873abb1d443853b8398ddf57c62e5c218..cc20bb14f73ae3cf786d08f659d796ab84299997 100644 (file)
@@ -308,6 +308,10 @@ _gdk_wayland_cursor_set_scale (GdkCursor *cursor,
 
   wayland_cursor->scale = scale;
 
+  /* Blank cursor case */
+  if (g_strcmp0 (wayland_cursor->name, "none") == 0)
+    return;
+
   _gdk_wayland_cursor_update (display_wayland, wayland_cursor);
 }
 
@@ -345,12 +349,18 @@ _gdk_wayland_display_get_cursor_for_name_with_scale (GdkDisplay  *display,
                           "cursor-type", GDK_CURSOR_IS_PIXMAP,
                           "display", display,
                           NULL);
-  private->name = g_strdup (name);
-  private->scale = scale;
 
   /* Blank cursor case */
   if (!name || g_str_equal (name, "none") || g_str_equal (name, "blank_cursor"))
-    return GDK_CURSOR (private);
+    {
+      private->name = g_strdup ("none");
+      private->scale = scale;
+
+      return GDK_CURSOR (private);
+    }
+
+  private->name = g_strdup (name);
+  private->scale = scale;
 
   if (!_gdk_wayland_cursor_update (display_wayland, private))
     {